merge :: 공지사항 api 연동 #59
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JJIIIINN
reviewed
Mar 26, 2024
|
코멘트 반영하고 있는 건가요? |
Comment on lines
+13
to
+28
| try { | ||
| const { data } = await instance.get(`${process.env.NEXT_PUBLIC_BASE_URL}/notices`); | ||
| const fetchedNotices: NoticeListResponse[] = data.notices.map((notice: any) => ({ | ||
| id: notice.id, | ||
| title: notice.title, | ||
| created_at: new Date(notice.created_at).toISOString() | ||
| })); | ||
| setNotices(fetchedNotices); | ||
| } catch (error: any) { | ||
| append({ | ||
| title: "", | ||
| message: "공지사항 리스트 조회에 실패하였습니다.", | ||
| type: "RED", | ||
| }); | ||
| } | ||
| }; |
There was a problem hiding this comment.
try catch 말고 then catch문으로 통일 합시다
Comment on lines
18
to
21
| <h1 className="font-[700] text-[28px]">{noticeDetail?.title}</h1> | ||
| <h2 className="font-[500] text-[20px] mt-[20px]">{noticeDetail?.created_at.substring(0, 10)}</h2> | ||
| <p className="font-[400] text-[16px] mt-[28px] whitespace-pre-line">{noticeDetail?.content}</p> | ||
| <AttachedBox props={noticeDetail?.attachments || []} /> |
There was a problem hiding this comment.
noticeDetail 비구조화 할당 합시다.
Comment on lines
+14
to
+29
| try { | ||
| const response = await axios.get(`${process.env.NEXT_PUBLIC_IMAGE_URL}/${attachment.url}`, { | ||
| responseType: 'blob' | ||
| }); | ||
|
|
||
| const url = window.URL.createObjectURL(new Blob([response.data])); | ||
| const a = document.createElement("a"); | ||
| a.href = url; | ||
| a.download = file_name_regex(attachment.url); | ||
| document.body.appendChild(a); | ||
| a.click(); | ||
| window.URL.revokeObjectURL(url); | ||
| document.body.removeChild(a); | ||
| } catch (error) { | ||
| console.error('파일 다운로드 에러: ', error); | ||
| } |
KANGYONGSU23
approved these changes
Apr 19, 2024
| import { useGetNoticeDetailData } from "@/apis/notice"; | ||
| import AttachedBox from "@/components/notice/AttachedBox"; | ||
|
|
||
| export default function NoticeDetailPage(props:any) { |
There was a problem hiding this comment.
any 타입은 최대한 피해야 합니다. ts를 쓰는 이유가 없어져요.
jikwan0327
reviewed
Apr 20, 2024
Comment on lines
+42
to
+49
| title: data.title, | ||
| content: data.content, | ||
| created_at: new Date(data.created_at).toISOString(), | ||
| attachments: data.attachments.map((attachment: any) => ({ | ||
| url: attachment.url, | ||
| type: attachment.type | ||
| })) |
There was a problem hiding this comment.
이 부분은 그냥 data를 반환하면 안되나요? object로 한번 더 감싸는 이유가 무엇인가요?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
특이사항
관련 이슈